Skip to content

GH-964: Fix IndexOutOfBoundsException in Array.getResultSet() for JDBC clients #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbonofre merged 2 commits into from
Jan 17, 2026
Merged

GH-964: Fix IndexOutOfBoundsException in Array.getResultSet() for JDBC clients #965

jbonofre merged 2 commits into from
Jan 17, 2026
+31 −15

Conversation

@xborder
Copy link
Contributor

@xborder xborder commented Jan 12, 2026

What's Changed

  • Fixed JDBC specification in ArrowFlightJdbcArray.getResultSet() that caused IndexOutOfBoundsException in JDBC clients like DBeaver when reading array columns
  • The method returned a single-column ResultSet containing only array values, but JDBC spec requires a 2-column format
  • Not it returns two columns:
    • Column 1 (INDEX): 1-based element indices per JDBC specification
    • Column 2: The actual array element values

Closes #964.

@github-actions

This comment has been minimized.

Sign in to view
@xborder
Copy link
Contributor Author

xborder commented Jan 12, 2026

Could this be considered a breaking-change even though it is a fix to comply with the JDBC spec? How should this be handled?

@lidavidm
Copy link
Member

lidavidm commented Jan 12, 2026

I think it's not a breaking change to make it comply with the spec.

Can we make the title descriptive of the changes?

@xborder xborder changed the title GH-964: Return ResultSet GH-964: Fix IndexOutOfBoundsException in Array.getResultSet() for JDBC clients Jan 12, 2026
jbonofre
jbonofre approved these changes Jan 16, 2026
View reviewed changes
Copy link
Member

@jbonofre jbonofre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it could be seen as a breaking change from a code perspective, I don't think it's a breaking change as it's aligned with the spec (I would rather consider as a bug fix).

@jbonofre jbonofre added the bug-fix PRs that fix a big. label Jan 16, 2026
@github-actions github-actions bot added this to the 19.0.0 milestone Jan 16, 2026
@jbonofre jbonofre merged commit 349d402 into apache:main Jan 17, 2026
57 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbonofre jbonofre jbonofre approved these changes

@lidavidm lidavidm Awaiting requested review from lidavidm lidavidm is a code owner

@laurentgo laurentgo Awaiting requested review from laurentgo laurentgo is a code owner

@wgtmac wgtmac Awaiting requested review from wgtmac wgtmac is a code owner

Assignees

No one assigned

Labels

bug-fix PRs that fix a big.

Projects

None yet

Milestone

19.0.0

Development

Successfully merging this pull request may close these issues.

DBeaver fails to display columns of array type

3 participants

@xborder @lidavidm @jbonofre